Posts by dre

    It does not improve anything for all users who use a different language then English as SvenH correctly explained. So, you have fixed something that very likely nobody even had an issue with but introduced a new problem.

    This post is from dev for dev


    Project DreamLegacy


    Setting up a build environment for opendreambox (pyro/krogoth) from scratch and building DreamOS images has not been possible for quite some time due to no longer available repositories on git.opendreambox.org.


    In order to keep Dream's legacy alive I have decided to move all repositories - including those formerly hosted on git.opendreambox.org - to my own github and fix the build process.


    This repository only fixes issues and does not provide any updated packages. Requirements for host system are unchanged.


    Just clone opendreambox repository to start like you did when using the original repository:


    Krogoth

    Code
    git clone -b krogoth git@github.com:dreamlegacy/opendreambox.git


    Pyro

    Code
    git clone -b pyro git@github.com:dreamlegacy/opendreambox.git


    Important: This repository is to build DreamOS images for original hardware (DM52x, DM820, DM9x0, DM7080, One, Two). Any other use is forbidden.

    Mach die Box für ein paar Stunden stromlos. Am besten auch gleich noch Kabel zu HDD (falls vorhanden) und Frontpanel entfernen.


    Dann einstecken und schauen, ob sie so bootet. Bei mir war es damals das Kabel zum Frontpanel.

    Here's my feedback:

    Code
    srvRef = eServiceReference(ref.toString())

    No added value compared to Dr.Best's implementation.

    Code
            epgcache = self.epgcache
            getEvent = self.getEventTuple

    You just assign a function/instance to a variable with no added value.


    Code
            max_offset = self.max_search_offset  # Step size for searching
            max_limit = self.max_search_limit    # Maximum total search range

    No added value to assign to variable known to this function only.


    Code
    while len(contentList) < self.eventcount and total_offset < max_limit:

    Just a simple example: Skinner sets event count to 10 and maxSearchOffset to 1 hour. You have 2 events within the timespan.


    len(contentlist) will never reach 10 and you'll loop forever. As you have two limits introduced (quantity and time), you have to be more careful.


    Either you have to ensure that only one of the two can be provided or you must cover the cases properly.


    Code
                        next_event = epgcache.lookupEventTime(srvRef, next_time + offset)
                        if next_event:
                            found_event = next_event
                            break

    why do you assign next_event to found_event? you can work with next_event the whole time.


    And last one: I'm not a fan of try/except. There are cases where it makes sense but here I don't see why it should be required.

    The developer added 9 "wait" files to the spinner folder, and now the system is telling me that the file wait10.png is missing. How can I get it?!

    The developer did not add the file notification_mail.png. How can I get it?!

    The developer did not add the files (ico_dvb_s-fs8, ico_dvb_c-fs8, ico_dvb_t-fs8, ico_service_group-fs8). How can I get them?!

    The developer did not add RassLogo and state. How can I get them?!

    Generate them yourself? If warnings that do have zero impact on any functionality of your dreambox are an issue for you, then it's a simple two liner (and one import) to get rid of most of them. E.g. the icons for reception type have been added that skinners who would like to show them in channellist can do that easily but they have never been included by default.


    Jan 26 15:43:08 dm520 enigma2[150]: WARNING! ConfigEnableDisable is deprecated, please use ConfigOnOff instead!

    This is a warning that is very helpful and tells devs that they should no longer use ConfigEnableDisable. This is not a but but a very important information.