I'm sorry... I shouldn't have released this version this early (3:00 in the morning)
I will check the errors and paste a new Version after that.
Tode
AC3 Lip Sync Plugin Version 0.7-2009-07-29-r0
-
Also das läuft auch auf der 8000er, nur so als Info.
-
You have made a great plugin but there are some problems: latest version (02-22-r0) does not always keep the correct playback position during adjustment, sometimes it just starts playback from the beginning.
Another problem is that when I adjust (PCM) delay during movie playback, press Green-button and then press Exit-button twice to close the menus, I get a messagebox asking if I want to resume playback from the last position. And I get that messagebox many times, looks like if I adjust delay for example 5 steps, I also get the messagebox 5 times...
In Enigma's options I have set Resume from last position = ask user. If I set it to "yes", I get just one messagebox saying that playback resumes from the last position. But I don't want to use that setting.
I'm using Enigma2 CVS version 16.1.2009, I don't know if this happens with latest versions.
-
Finally fixed the messagebox- Bug. New Version in the first post...
Thank you!
There is still a problem with the playback position, sometimes it resets to the start of the movie. Looks like it happens always if I adjust (PCM) delay too fast, i.e. press arrow keys 2-4 times without waiting picture to appear. Just try this: press right arrow once and then during that very short period of black screen, press right arrow 2-3 times.
-
Few things:
1.) I'm trying to make a Finnish language translation but "Step in ms for key %i" in the setup menu does not translate, looks like there is something wrong in the Python code of AC3Setup.py.
2.) I think that you should use green key for storing the settings, that is the standard in all other menus. Then again, I liked the way this was before i.e. green for OK, blue to store the values.
3.) And finally, I think that selection of calculated/user values (and storing of user values) are really not necessary in the main panel. Setup panel's number key setting is enough. -
Looks like the playback position reset is fixed if I change the file AC3delay.py, in def activateDelay I changed self.timer.start value from 400 to 200. But I haven't tested if this causes other problems...
Other thing I noticed is that main screen skin does not show "AC3:" and "PCM:" texts correctly in the Channel audio row, text is clipped and only "AC" and "PC" is show, also PCM value is missing the "ms" text. I have fixed this by reducing font size to 18 and making those fields a little wider. I know this is not a problem with all skins but looks like it partly happens also with the skin you are using.
With the latest CVS version, setup screen's "Step in ms for key %s" still doesn't seem to translate to other languages.
-
The problem was that you replaced the variable before passing the string to gettext but you already fixed this when you changed it to use a string value (which is kinda useless but does not do any harm - except for breaking the italian translation :P).
Named variables are useful if you have to change the order in other languages for some reason but is absolutely useless if you only have one variable to replace.
-
If you have the time, you could change this code in the AC3Setup.py and report, if this version can be translated (update your po from source and translate the new string)
I tested and it still didn't work. I then added this string to the po: "Step in ms for key 1", made a translation for it and now the setup screen shows this one line correctly translated. So looks like there may still be something wrong with the variable. I think/hope that I put the line correctly to the po... -
-
Hi, ich denke die halbe Nation ist heiße auf eine neue Version, das Delay bei der DM800/8000 nervt tierisch. Wäre super wenn du bald dafür Zeit dafür hättest.
Mfg David
