Dreamboard

aholst · 23. Dezember 2007

There is a new version of the MovieRetitle plugin, 1.1. (The first version, 1.0, was announced together with the MovieCut plugin).

MovieRetitle lets you change the filename, title, and description of a movie. It shows up in the movie list menu as "Change name".

It is thus similar in functionality to Gutemine's RenameMovie plugin, although it has a more convenient and simple interface: You get directly into a dialog where you can (independently) edit any or all of the filename, the title, or the description of the movie. When you are done you immediately get back to the updated movie list. Also, this plugin does not require the filename and title to be synchronized as Gutemine's plugin does. On the other hand, Gutemine's plugin offers the possibility to also rename Enigma1 movies and mpeg files, whereas this plugin concentrates on movies recorded under Enigma2. (If there is a demand for it, one might of course consider to make a hybrid with the best parts of our two plugins.)

This version of MovieRetitle requires a version of Enigma2 from later than 2007-11-28, which means that it can now be used together with the Dreambox keyboard, and that long movie names or descriptions appear better in the dialog (scrolled horizontally rather than only showing the last part). It is also based entirely on python code, as opposed to the previous version which called external programs for the renaming. This means that this version should be possible to use on any Dreambox model running Enigma2, and not just DM7025.

Both an .ipk and a .tar.bz2 version of the plugin is attached below.

Best Regards
Anders Holst

Tode · 27. Dezember 2007

I needed a function to automatically fill the description with text from the extended description because some senders do not send a correct description for the events.

I added the functionality to your great plugin:

if description is empty and extended Description contains <'> then the description is replaced by the part of the extended description between the two ' ' characters.

Example:

On start of the plugin:

Description = ""
Extended description: Folge 10: 'The best friend': Theo meets...

After start:
Description = The best friend

Here is the code I changed:

Python

from Plugins.Plugin import PluginDescriptor
from Screens.Screen import Screen
from Screens.MessageBox import MessageBox
from Components.config import *
from Components.ActionMap import ActionMap, NumberActionMap
from Components.ConfigList import ConfigList, ConfigListScreen
from Components.Button import Button
from Components.Label import Label
from Components.Pixmap import Pixmap
from enigma import eServiceReference, eServiceCenter, iServiceInformation
import os


def main(session, service, **kwargs):
	MovieRetitle(session, service, **kwargs)


def Plugins(**kwargs):
	return PluginDescriptor(name="MovieRetitle", description=_("Change name..."), where = PluginDescriptor.WHERE_MOVIELIST, fnc=main)




class MovieRetitle(Screen):
	def __init__(self, session, service, args = 0):
		self.session = session
		self.service = service
		Screen.__init__(self, session)
		serviceHandler = eServiceCenter.getInstance()
		info = serviceHandler.info(self.service)
		self.path = self.service.getPath()
+		self.descrChanged = False
		if self.path.endswith(".ts") is True:
			self.path = self.path[:-3]
		self.name = info.getName(self.service)
		self.descr = info.getInfoString(self.service, iServiceInformation.sDescription)
+		if self.descr == "":
+       		event = info.getEvent(self.service)
+        		extDescr = event.getExtendedDescription()
+                       extArr = extDescr.split("'",3)
+                       self.descr = extArr[1]
+                       self.descrChanged = True
-		self.session.openWithCallback(self.renameConfirmed, TitleDescrInput, self.name, self.path, self.descr)
+		self.session.openWithCallback(self.renameConfirmed, TitleDescrInput, self.name, self.path, self.descr, self.descrChanged)


	def renameConfirmed(self, ret):
		if len(ret) <= 1 or not ret[0]:
			return self.close()
		if ret[2] != False or ret[3] != False:
			self.setTitleDescr(self.path, ret[2], ret[3])
		if ret[1] != False:
			self.maybeMoveMovieFiles(self.path, ret[1])
		else:
			self.exitDialog()


	def setTitleDescr(self, file, title, descr):
		if os.path.exists(file + ".ts.meta"):
			metafile = open(file + ".ts.meta", "r")
			sid = metafile.readline()
			oldtitle = metafile.readline().rstrip()
			olddescr = metafile.readline().rstrip()
			rest = metafile.read()
			metafile.close()
			if not title and title != "":
				title = oldtitle
			if not descr and descr != "":
				descr = olddescr
			metafile = open(file + ".ts.meta", "w")
			metafile.write("%s%s\n%s\n%s" %(sid, title, descr, rest))
			metafile.close()


	def maybeMoveMovieFiles(self, fr, to):
		if os.path.exists(to+".ts"):
			self.inter_fr = fr
			self.inter_to = to
			self.session.openWithCallback(self.confirmedReplace, MessageBox, _("Target file") + " " + to + ".ts " + _("already exist.") + "\n" + _("Do you want to replace it?"), MessageBox.TYPE_YESNO)
		else:
			self.moveMovieFiles(fr, to)
			self.exitDialog()


	def confirmedReplace(self, answer):
		if answer == True:
			self.moveMovieFiles(self.inter_fr, self.inter_to)
		self.exitDialog()


	def moveMovieFiles(self, fr, to):
		self.moveOneFile(fr, to, ".ts")
		self.moveOneFile(fr, to, ".ts.cuts")
		self.moveOneFile(fr, to, ".ts.ap")
		self.moveOneFile(fr, to, ".ts.meta")
		self.moveOneFile(fr, to, ".eit")


	def moveOneFile(self, fr, to, suff):
		if os.path.exists(fr+suff):
			os.rename(fr+suff, to+suff)


	def exitDialog(self):
		session = self.session
		self.close()
		# This will try to get back to an updated movie list.
		# A proper way to do this should be provided in enigma2.
		try:
			session.current_dialog.csel.reloadList()
			session.current_dialog.close()
		except AttributeError:
			pass


class TitleDescrInput(Screen, ConfigListScreen):
	skin = """
	<screen name="TitleDescrInput" position="100,150" size="500,200" title="Name and Description Input">
		<widget name="config" position="5,10" size="480,150" />
		<widget name="ok" position="110,165" size="53,30" pixmap="ok.png" />
		<widget name="oktext" position="110,165" size="53,30" valign="center" halign="center" zPosition="2" font="Regular;20" transparent="1" />
		<widget name="cancel" position="310,165" size="100,30" pixmap="cancel.png" />
		<widget name="canceltext" position="310,165" size="100,30" valign="center" halign="center" zPosition="2" font="Regular;20" transparent="1" />
	</screen>"""


-	def __init__(self, session, name, path, descr):
+	def __init__(self, session, name, path, descr, descrChanged):
		self.skin = TitleDescrInput.skin
		Screen.__init__(self, session)


		self["oktext"] = Label(_("OK"))
		self["canceltext"] = Label(_("Cancel"))
		self["ok"] = Pixmap()
		self["cancel"] = Pixmap()


		if self.baseName(path) == self.baseName(name):
			self.title = ""
		else:
			self.title = name
		self.dir = self.dirName(path)
		self.path = self.baseName(path)
		self.descr = descr
+		self.descrChanged = descrChanged
		self.input_path = ConfigText(default = self.path, fixed_size = False, visible_width = 42)
		self.input_title = ConfigText(default = self.title, fixed_size = False, visible_width = 42)
		self.input_descr = ConfigText(default = self.descr, fixed_size = False, visible_width = 42)


		self["actions"] = NumberActionMap(["SetupActions"],
		{
			"ok": self.keyGo,
			"save": self.keyGo,
			"cancel": self.keyCancel,
		}, -2)


		self.list = []
		ConfigListScreen.__init__(self, self.list)
		self.createSetup(self["config"])


	def createSetup(self, configlist):
		self.list = []
		self.list.append(getConfigListEntry(_("Filename"), self.input_path))
		self.list.append(getConfigListEntry(_("Title"), self.input_title))
		self.list.append(getConfigListEntry(_("Description"), self.input_descr))
		configlist.list = self.list
		configlist.l.setList(self.list)


	def keyGo(self):
		if self.input_path.value == self.path:
			self.path = False
		else:
			self.path = self.rejoinName(self.dir, self.input_path.value)
		if self.input_title.value == self.title:
			self.title = False
		else:
			self.title = self.input_title.value
-		if self.input_descr.value == self.descr:
+		if self.input_descr.value == self.descr and self.descrChanged == False:
			self.descr = False
		else:
			self.descr = self.input_descr.value
		self.close((True, self.path, self.title, self.descr))


	def keyCancel(self):
		self.close((False, ))


	def baseName(self, str):
		name = str.split('/')[-1]
		if name.endswith(".ts") is True:
			return name[:-3]
		else:
			return name


	def dirName(self, str):
		return '/'.join(str.split('/')[:-1]) + '/'


	def rejoinName(self, dir, name):
		name = name.strip()
		if name.endswith(".ts") is True:
			return dir + name[:-3]
		else:
			return dir + name

Alles anzeigen

Probably you find it usefull for changes in future.
But be careful: There is no error- handling in this code at the moment. Whenever there is no ' in the text it will crash enigma. I will fix that when I am back at home.
regards
Tode

aholst · 8. Januar 2008

Hello Tode

Thanks for your contribution to the code. I think it is a good idea to use material from the long description when the short description is empty.

I just have two minor thoughts regarding it:

First, how can really the short description be missing and not the long one? (Or the other way around for that matter, or sometimes there are even descriptions of different movies in the long and short one.) Both the short and long descriptions must be from the EPG, so if it manages to capture one correctly it should capture the other one too. Yet I experience this discrepancy rather often. I think it is a bug, and as such it should preferably be fixed at the source rather than worked around. (This is not to say that the workaround can't be valuable until the real bug is fixed of course - please continue sending updates!)

Second, I am not sure about this trick with the quotes. The crash you mention can be fixed of course, but my point is this: Are the quotes around the episode name some kind of common convention? I seldom see any such quotes in the descriptions of the movies I get here. Maybe there should be some other way to pick out the relevant part? Or just insert all of it if there are any uncertainty. (Actually, many times it seems that the long and short descriptions are the same here.)

So, what is the optimal behavior here really?

Best Regards
Anders Holst

aholst · 8. Januar 2008

Due to a small mistake when packaging the .ipk file it couldn't be installed. A new version is uploaded in its place above (at the first message in the thread). Better luck with this one!

Best Regards
Anders Holst

Tode · 8. Januar 2008

Thanx for your answer.

I already updated my code to prohibit the crash.
I created a completely new py- File with 2 new functions called:

GetDescriptionWithFallbackFromService(service)

and

GetDescriptionWithFallbackFromEvent(event,descr)

These to functions take either a service or an event as parameters and try to give back a "sensible" description (whereas the second one takes a "default"- or "fallback"- description as parameter).

I can not speak for a "general standard". But I looked at a lot- of german stations and found out some interesting things:

A lot of them seem to send a long- description (EPG) only, but no short- description. The title -e.g. of series- very often is empty, but is shown in addition in the long- description.

Whether the stations do not send this information, or if the Dreambox does not read it correctly, is something, that I could not find out yet.

From my experience with german stations I implemented the following search- order:

Search for double quotes: if found, take the text in between
Search for single quotes: if found, take the text in between
Search for colon: if found, take the text before the colon
Search for dot: if found take the text before the first dot
else: Take the first 20 characters.

This information is mostly true for series (e.g. Heroes, Emergency Room, etc.), not for Movies, where the Short- Description most often is empty, or filled with something like a genre ("Comedy") or something.

Best thing would be, to make the search- order configurable in a config- screen, and probably to let the user define his own special characters to search for. You could as well let him choose the number of characters to use, if the characters were not found.

I'll attach my new "MovieUtils.py" that I copied to the Components- folder as well as two implementations: Your Movie- Retitle and a change in RecordTimer.py.

Probably you can use it.
Best regards

Tode

aholst · 22. Juli 2008

There is a new version of the MovieRetitle plugin available.

It is now possible to move to another location. If the other location is on another device, moving will be performed in the background and a notification given when moving is finished. The old movie will not disappear from the movie list until then. It is possible to request moving more movies before the first one has finished, but they will be queued up and moved after each other not the stress the external media too much.

This version is adapted to the skin changes of 2008-04-14 and requires the "location stuff" changes of 2008-06-28.

The version does *not* include the patch by Tode to handle extended description, since I'm still not sure about the best practice here, and there seem to be differences between countries. But I welcome Tode to provide a patched version of this version too.

Included below are ipk and tar.bz2 files. This version can also be downloaded from the plugin menu if you use the experimental feed.

Best Regards
Anders Holst

aholst · 25. Juli 2008

The above version of MovieRetitle, 1.2, requires the location patches that came in place 2008-06-26 (I wrote 28th above, that was slightly wrong I see now). Still, many people may have images based on versions of Enigma2 before that date but still after the skin changes on 2008-04-14.

To make MovieRetitle available to them, I have made a minor "backport" of the plugin, intended for the Enigma2 2.5 branch between 2008-04-14 and 2008-06-26. The location support is "crippled" back to the pre-26th-june level, but otherwise everything should be the same in the plugin.

Best Regards
Anders Holst

Tode · 29. September 2008

It's been a while, since you added this Version. But I did not have time until today to insert my modifications into the code.

Here is my Version of the plugin.py. It uses my "MovieUtils.py" to try to guess a good Short- Description from the Extended- Description.

I use it to rename the recordings of "Heroes" from RTL2: They do not send a Short- Description but only a Extended- Description, that contains the title of the current series.

This is NOT the backported Version but the original one...

Best rergards
Tode