Why does DMM not look at OpenPLi and commit what they did into git... ?
We solved the breaking lines (which in fact is due to a big bug spagetti code). Add borders to the subtitles (black border around the characters not bars). Made multiple colours per line possible (changes in font.cpp)
Just convince the Pli-guys to send their stuff as patches to the development mailing list and somebody will have a look at it.
Just convince the Pli-guys to send their stuff as patches to the development mailing list and somebody will have a look at it.
Thanks.
ZitatJust convince the Pli-guys to send their stuff as patches to the development mailing list and somebody will have a look at it.
Why not just take a look at openpli git and commit it back? Or that someone else could try to make the commit. Especially in font.cpp there are curremty a lot of differences....
Answer from PLi guys
.
They cannot just take our GPL enigma2 code, and put it under their custom license.
That's a problem they created for themselves; everybody can use their code, derivates automatically fall under the GPL license. But as a result, the route back is more or less blocked, GPL code cannot flow back under the original license, unless the 'owner' donates it back, and gives up all the rights.
We've done that in the past before we had a public GPL repository, and in general we don't care about our 'rights', but it turned out to be a lot of effort, especially when the patches are not simple oneliners, and we have to convince the dmm coders that they really add something.
And the font outline rendering, if you include that in the 'subtitling stuff', is not really a simple 'addon' for e2, as it means we cannot use the efficient glyph cache anymore. So that would certainly raise some questions.
The linebreak stuff on the other hand is simple. They could have done the same actually, the current dmm e2 subtitle combining algorithm is just a choice that they made, but unfortunately doesn't give very nice results for most channels.
They can ask.... I'm sure that PLi will give it back...
This is still irritating... not only for teletekst subtitles currently also the graphic DVB subtitels are too long on the screen. The color/linebrake issue should be fixed...
But the fix posted here is also tricky. I analyzed the code and conclude In fact you should create for each line a new element (and not put two lines to an element). In the element we can store one line that can exists of more words (BBC) if they are on the same element line, so first search for if the line already exists before adding a new element.
And when a new page started all elements should be cleared... (all in subtitles.cpp). In esubtitles.cpp we must get through all elements and post it on a position depended on the line position. I think this will make proper subtitles and also possible to put each line in a different color. (one color per line not per word).
So, dear DMM... 1,5+ year now.
Still waiting... 
Still waiting here too...
Still waiting here too...Still waiting here too...
Still waiting here too...
